Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeStyle][task 14] enable Ruff PLR1722 rule in python/paddle/base #57401

Merged
merged 4 commits into from
Sep 20, 2023
Merged

[CodeStyle][task 14] enable Ruff PLR1722 rule in python/paddle/base #57401

merged 4 commits into from
Sep 20, 2023

Conversation

ooooo-create
Copy link
Contributor

@ooooo-create ooooo-create commented Sep 15, 2023 •
edited by SigureMo
Loading

PR types

Others

PR changes

Others

Description

auto fix
@gouzil

@paddle-bot
Copy link

paddle-bot bot commented Sep 15, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 15, 2023
@gouzil gouzil mentioned this pull request Sep 16, 2023
Closed
@gouzil
Copy link
Member

gouzil commented Sep 16, 2023

rerun 一下 ci

@ooooo-create ooooo-create changed the title [CodeStyle][task 14] enable Ruff PLR1722 rule in python/paddle/base [CodeStyle][task 14] enable Ruff PLR1722 rule in python/paddle/base Sep 16, 2023
@ooooo-create
Copy link
Contributor Author

rerun 一下 ci

rerun是点进去然后点重新构建嘛~
PR-CI-Coverage好像不让重新构建

@gouzil
Copy link
Member

gouzil commented Sep 16, 2023

rerun是点进去然后点重新构建嘛~ PR-CI-Coverage好像不让重新构建

PR-CI-Coverage 是覆盖率问题，等豁免就行了

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Sep 18, 2023
@gouzil
Copy link
Member

gouzil commented Sep 18, 2023

LGTM @SigureMo

@gouzil
Copy link
Member

gouzil commented Sep 19, 2023

rerun 一下 PR-CI-GpuPS

@luotao1
Copy link
Contributor

luotao1 commented Sep 19, 2023

冲突了

@ooooo-create
Copy link
Contributor Author

冲突了

Done

SigureMo
SigureMo approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 merged commit ab4a6f9 into PaddlePaddle:develop Sep 20, 2023
27 checks passed
@ooooo-create ooooo-create deleted the ooooo/PLR1722 branch September 23, 2023 05:24
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
@ooooo-create @Frida-a
[CodeStyle][task 14] enable Ruff PLR1722 rule in python/paddle/base (P…
694c80d 
…addlePaddle#57401)
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@ooooo-create
[CodeStyle][task 14] enable Ruff PLR1722 rule in python/paddle/base (P…
8003ed6 
…addlePaddle#57401)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees

@luotao1 luotao1

@SigureMo SigureMo

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ooooo-create @gouzil @luotao1 @SigureMo