Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeStyle][task 39] enable isort in python/paddle/base (part1) #57413

Merged
merged 5 commits into from
Sep 21, 2023
Merged

[CodeStyle][task 39] enable isort in python/paddle/base (part1) #57413

merged 5 commits into from
Sep 21, 2023

Conversation

ccsuzzh
Copy link
Contributor

@ccsuzzh ccsuzzh commented Sep 16, 2023

PR types

Others

PR changes

Others

Description

enable isort rule in python/paddle/base

@ccsuzzh
Copy link
Contributor Author

ccsuzzh commented Sep 16, 2023

看错了，以为F401已经修完了（：

@SigureMo SigureMo changed the title [CodeStyle][task 39] enable isort rule in python/paddle/base [CodeStyle][task 39] enable isort in python/paddle/base Sep 16, 2023
@SigureMo SigureMo changed the title [CodeStyle][task 39] enable isort in python/paddle/base [CodeStyle][task 39] enable isort in python/paddle/base Sep 16, 2023
@paddle-bot paddle-bot bot added the contributor External developers label Sep 16, 2023
@SigureMo
Copy link
Member

#57388 F401 已经合入，可以重做一下这个 PR 了～

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Sep 18, 2023
@ccsuzzh ccsuzzh closed this Sep 18, 2023
@ccsuzzh ccsuzzh reopened this Sep 18, 2023
@ccsuzzh
Copy link
Contributor Author

ccsuzzh commented Sep 18, 2023

#57388 F401 已经合入，可以重做一下这个 PR 了～

Done

@SigureMo
Copy link
Member

image

PR-CI-Windows rerun 好几次都会挂，看样子直接 sort 是有问题的

可以这个 PR 暂时 exclude 掉 python/paddle/base/core.py，之后新的 PR 再处理 python/paddle/base/core.py

@ccsuzzh
Copy link
Contributor Author

ccsuzzh commented Sep 20, 2023

image PR-CI-Windows rerun 好几次都会挂，看样子直接 sort 是有问题的

可以这个 PR 暂时 exclude 掉 python/paddle/base/core.py，之后新的 PR 再处理 python/paddle/base/core.py

Done

@SigureMo
Copy link
Member

冲突了 😂

@SigureMo SigureMo changed the title [CodeStyle][task 39] enable isort in python/paddle/base [CodeStyle][task 39] enable isort in python/paddle/base (part1) Sep 20, 2023
SigureMo
SigureMo approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

剩下的两个文件可以新提 PR 解决，如果只有 python/paddle/base/framework.py 有问题可以考虑在文件内用 # isort: skip_file，同 python/paddle/jit/api.py 中的处理方式，可以手动大致 sort 一下

这个 PR 是 isort 的 part1

@SigureMo SigureMo mentioned this pull request Sep 20, 2023
Merged
@luotao1 luotao1 merged commit c4dd109 into PaddlePaddle:develop Sep 21, 2023
27 checks passed
@luotao1 luotao1 mentioned this pull request Sep 21, 2023
Closed
@ccsuzzh
Copy link
Contributor Author

ccsuzzh commented Sep 21, 2023

LGTMeow 🐾

剩下的两个文件可以新提 PR 解决，如果只有 python/paddle/base/framework.py 有问题可以考虑在文件内用 # isort: skip_file，同 python/paddle/jit/api.py 中的处理方式，可以手动大致 sort 一下

这个 PR 是 isort 的 part1

好的^v^

@ccsuzzh ccsuzzh deleted the fix_isort branch September 21, 2023 03:09
iosmers pushed a commit to iosmers/Paddle that referenced this pull request Sep 21, 2023
@ccsuzzh
[CodeStyle][task 39] enable isort in python/paddle/base (part1) (Pa…
a7c23e2 
…ddlePaddle#57413)

* enable isort rule in python/paddle/base

* fix bug

* fix bug

* fix bug
This was referenced Sep 25, 2023
Merged
Merged
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
@ccsuzzh @Frida-a
[CodeStyle][task 39] enable isort in python/paddle/base (part1) (Pa…
78f8f01 
…ddlePaddle#57413)

* enable isort rule in python/paddle/base

* fix bug

* fix bug

* fix bug
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
@ccsuzzh @jiahy0825
[CodeStyle][task 39] enable isort in python/paddle/base (part1) (Pa…
10b0b0b 
…ddlePaddle#57413)

* enable isort rule in python/paddle/base

* fix bug

* fix bug

* fix bug
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@ccsuzzh
[CodeStyle][task 39] enable isort in python/paddle/base (part1) (Pa…
57f4c2e 
…ddlePaddle#57413)

* enable isort rule in python/paddle/base

* fix bug

* fix bug

* fix bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees

@luotao1 luotao1

@SigureMo SigureMo

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccsuzzh @SigureMo @luotao1