Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xdoctest] reformat example code with google style No.354 #57440

Merged
merged 4 commits into from
Sep 19, 2023
Merged

[xdoctest] reformat example code with google style No.354 #57440

merged 4 commits into from
Sep 19, 2023

Conversation

PommesPeter
Copy link
Contributor

@PommesPeter PommesPeter commented Sep 18, 2023 •
edited
Loading

megemini
megemini reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@megemini megemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version 的 结果 都加一下 skip 吧，毕竟不是固定的东西 ～

python/setup.py.in Outdated Show resolved Hide resolved
python/setup.py.in Outdated Show resolved Hide resolved
python/setup.py.in Outdated Show resolved Hide resolved
python/setup.py.in Outdated Show resolved Hide resolved
python/setup.py.in Outdated Show resolved Hide resolved
python/setup.py.in Outdated Show resolved Hide resolved
@paddle-bot paddle-bot bot added the contributor External developers label Sep 18, 2023
SigureMo
SigureMo reviewed Sep 19, 2023
View reviewed changes
python/setup.py.in Outdated Show resolved Hide resolved
python/setup.py.in Outdated Show resolved Hide resolved
python/setup.py.in Outdated Show resolved Hide resolved
python/setup.py.in Outdated Show resolved Hide resolved
python/setup.py.in Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
SigureMo
SigureMo reviewed Sep 19, 2023
View reviewed changes
python/setup.py.in Outdated Show resolved Hide resolved
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 label Sep 19, 2023
SigureMo
SigureMo approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 merged commit da5cc73 into PaddlePaddle:develop Sep 19, 2023
@luotao1 luotao1 mentioned this pull request Sep 19, 2023
Closed
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
@PommesPeter @SigureMo @Frida-a
[xdoctest] reformat example code with google style No.354 (PaddlePadd…
b4987c5 
…le#57440)

* updated setup.py xdoctest

* updated setup.py.in xdoctest

* updated skip test

* Apply suggestions from code review

---------

Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@PommesPeter @SigureMo
[xdoctest] reformat example code with google style No.354 (PaddlePadd…
ddf16b0 
…le#57440)

* updated setup.py xdoctest

* updated setup.py.in xdoctest

* updated skip test

* Apply suggestions from code review

---------

Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megemini megemini megemini left review comments

@SigureMo SigureMo SigureMo approved these changes

Assignees

@luotao1 luotao1

@SigureMo SigureMo

@sunzhongkai588 sunzhongkai588

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PommesPeter @megemini @SigureMo @luotao1 @sunzhongkai588