Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in gloo.cmake #57443

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix bug in gloo.cmake #57443

merged 1 commit into from
Sep 18, 2023

Conversation

zrr1999
Copy link
Member

@zrr1999 zrr1999 commented Sep 18, 2023

PR types

Bug fixes

PR changes

Others

Description

在比较新的版本中,原本的 git checkout -- . && git checkout ${GLOO_TAG} &&patch -Nd 被识别成了
git checkout -- . && git checkout ${GLOO_TAG} “&&patch” -Nd,会报一个git不存在-N的参数,修改成 git checkout -- . && git checkout ${GLOO_TAG} && patch -Nd 则不会有这个问题,目前只在 gloo.cmake 里发现了这个情况,其他的文件中不存在这个问题

@zrr1999 zrr1999 requested a review from SigureMo September 18, 2023 06:02
@zrr1999 zrr1999 changed the title fix bug fix bug in gloo.cmake Sep 18, 2023
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo merged commit d985918 into PaddlePaddle:develop Sep 18, 2023
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants