Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeStyle][task 3] enable Ruff PLR1711 rule in python/paddle/base #57444

Merged
merged 4 commits into from
Sep 19, 2023
Merged

[CodeStyle][task 3] enable Ruff PLR1711 rule in python/paddle/base #57444

merged 4 commits into from
Sep 19, 2023

Conversation

zrr1999
Copy link
Member

@zrr1999 zrr1999 commented Sep 18, 2023

PR types

Others

PR changes

Others

Description

enable Ruff PLR1711 rule in python/paddle/base

@zrr1999 zrr1999 mentioned this pull request Sep 18, 2023
Closed
SigureMo
SigureMo reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

paddle ❯ ruff . --statistics --select=PLR1711
144     PLR1711 [*] Useless `return` statement at end of function

不止 base 里的哦，非 base 的也需要解决

pyproject.toml
@@ -70,7 +70,7 @@ select = [
"PLR0206",
"PLR0402",
"PLR1701",
# "PLR1711", # Confirmation required
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后面的注释删掉就好

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@zrr1999
Copy link
Member Author

zrr1999 commented Sep 18, 2023 

paddle ❯ ruff . --statistics --select=PLR1711
144     PLR1711 [*] Useless `return` statement at end of function

不止 base 里的哦，非 base 的也需要解决

好的已添加

SigureMo
SigureMo reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他地方应该没啥问题，动转静单测可能依赖于语法结构

test/dygraph_to_static/test_error.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个单测里可能依赖于行号，不太清楚这里 31 行删掉后是否会影响单测结果，可以本地测一下，如果改了的话，需要同步改动行号

test/dygraph_to_static/test_program_translator.py Outdated
Copy link
Member

@SigureMo SigureMo Sep 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件相关位置加 noqa 吧，虽然这些代码貌似没用到，但最好保持转写后代码的原貌

@zrr1999
Copy link
Member Author

zrr1999 commented Sep 18, 2023

其他地方应该没啥问题，动转静单测可能依赖于语法结构

已添加noqa

@SigureMo SigureMo changed the title [CodeStyle][task 3] enable Ruff PLR1711 rule in python/paddle/base [CodeStyle][task 3] enable Ruff PLR1711 rule in python/paddle/base Sep 18, 2023
@paddle-bot paddle-bot bot added the contributor External developers label Sep 18, 2023
SigureMo
SigureMo approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Sep 19, 2023
@luotao1 luotao1 merged commit bf06389 into PaddlePaddle:develop Sep 19, 2023
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
@zrr1999 @Frida-a
[CodeStyle][task 3] enable Ruff PLR1711 rule in python/paddle/base (P…
f67a22c 
…addlePaddle#57444)
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@zrr1999
[CodeStyle][task 3] enable Ruff PLR1711 rule in python/paddle/base (P…
caa6d06 
…addlePaddle#57444)
@zrr1999 zrr1999 mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees
No one assigned
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zrr1999 @SigureMo @luotao1