Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PIR] Add op_trait and type_util #57580

Merged
merged 21 commits into from
Oct 9, 2023
Merged

[PIR] Add op_trait and type_util #57580

merged 21 commits into from
Oct 9, 2023

Conversation

zhangbopd
Copy link
Contributor

PR types

Others

PR changes

Others

Description

  • Add op trait
  • Add type util

Other

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Sep 21, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhangbo9674
zhangbo9674 previously approved these changes Sep 27, 2023
View reviewed changes
Aurelius84
Aurelius84 reviewed Sep 28, 2023
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

paddle/pir/core/op_trait.h Outdated Show resolved Hide resolved
paddle/pir/core/type_util.cc Show resolved Hide resolved
paddle/pir/core/type_util.cc Outdated Show resolved Hide resolved
paddle/pir/core/type_util.cc Outdated Show resolved Hide resolved
paddle/pir/core/type_util.cc Outdated Show resolved Hide resolved
paddle/pir/core/type_util.cc Outdated Show resolved Hide resolved
paddle/pir/core/type_util.cc Outdated Show resolved Hide resolved
test/cpp/pir/core/CMakeLists.txt Show resolved Hide resolved
@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Oct 5, 2023

Sorry to inform you that af46e9f's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

winter-wang
winter-wang previously approved these changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@winter-wang winter-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

phlrain
phlrain previously approved these changes Oct 8, 2023
View reviewed changes
@zhangbopd zhangbopd dismissed stale reviews from phlrain and winter-wang via 99b9464 October 8, 2023 09:05
winter-wang
winter-wang approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@winter-wang winter-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

winter-wang
winter-wang approved these changes Oct 8, 2023 •
edited
Loading
View reviewed changes
XiaoguangHu01
XiaoguangHu01 approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangbopd zhangbopd merged commit b23a0f4 into PaddlePaddle:develop Oct 9, 2023
@zhangbopd zhangbopd deleted the OP_traits branch October 9, 2023 02:48
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
@zhangbopd @Frida-a
[PIR] Add op_trait and type_util (PaddlePaddle#57580)
38db825 
* op_trait and type_util

* add unit test

* add expect_throw for ci converage

* fix for win ci
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
@zhangbopd @jiahy0825
[PIR] Add op_trait and type_util (PaddlePaddle#57580)
34e5a14 
* op_trait and type_util

* add unit test

* add expect_throw for ci converage

* fix for win ci
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@zhangbopd
[PIR] Add op_trait and type_util (PaddlePaddle#57580)
38d2a27 
* op_trait and type_util

* add unit test

* add expect_throw for ci converage

* fix for win ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winter-wang winter-wang winter-wang approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@phlrain phlrain phlrain approved these changes

@zhangbo9674 zhangbo9674 Awaiting requested review from zhangbo9674

@Aurelius84 Aurelius84 Awaiting requested review from Aurelius84

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zhangbopd @Aurelius84 @phlrain @XiaoguangHu01 @winter-wang @zhangbo9674