【CINN】Move basic ADT from ir/utils to ir/ #57587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
… cinn_move_basic_utils
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
* move basic ADT from ir/utils to ir/ * fix headfile path
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 16, 2023
* move basic ADT from ir/utils to ir/ * fix headfile path
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* move basic ADT from ir/utils to ir/ * fix headfile path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
pcard-72718
This PR move basic ADT including ir_visitor, ir_mutator and ir_printer from ir/utils to ir/
Reason :
Consider two points. The first point is that these classes are not utils semantically, but serve as base classes to assist in implementing specific functions. Second point, judging from the original implementation, the original developer of CINN hopes to implement the corresponding operator = << of IR in this file. Considering the koenig search rules, this is an interface of IR and should be placed under the IR namespace.