Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon 5th No.9】add multigammaln api -part #57599

Merged
merged 17 commits into from
Nov 17, 2023
Merged

【Hackathon 5th No.9】add multigammaln api -part #57599

merged 17 commits into from
Nov 17, 2023

Conversation

GreatV
Copy link
Contributor

@GreatV GreatV commented Sep 21, 2023 •
edited
Loading

PR types

New features

PR changes

APIs

Description

add multigammaln api
RFC: api design for multigammaln

@paddle-bot
Copy link

paddle-bot bot commented Sep 21, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 21, 2023
@Ligoml Ligoml mentioned this pull request Sep 22, 2023
Open
@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Oct 4, 2023

Sorry to inform you that bee08f6's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@luotao1
Copy link
Contributor

luotao1 commented Oct 16, 2023

@GreatV PR描述里贴一下RFC文档

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Oct 31, 2023

Sorry to inform you that 4b17276's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@paddle-ci-bot Paddle-ci-bot
Copy link

paddle-ci-bot bot commented Nov 9, 2023

Sorry to inform you that 7d50471's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@xuxinyi389
Copy link
Contributor

xuxinyi389 commented Nov 13, 2023 •
edited
Loading

您好，这样写测试是不符合规范的，应该构造计算反向的函数来验证。

xuxinyi389
xuxinyi389 reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@xuxinyi389 xuxinyi389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/legacy_test/test_multigammaln.py Show resolved Hide resolved
@GreatV GreatV mentioned this pull request Nov 16, 2023
Merged
jeff41404
jeff41404 previously approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GreatV @sunzhongkai588
Update python/paddle/tensor/math.py
7ec5076 
Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com>
@luotao1
Copy link
Contributor

luotao1 commented Nov 17, 2023

@GreatV 请补充对应的中文文档

@GreatV
Copy link
Contributor Author

GreatV commented Nov 17, 2023

@luotao1 好的，稍后补充。

sunzhongkai588
sunzhongkai588 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 changed the title 【Hackathon 5th No.9】add multigammaln api 【Hackathon 5th No.9】add multigammaln api -part Nov 17, 2023
@luotao1 luotao1 merged commit 4eb03dc into PaddlePaddle:develop Nov 17, 2023
27 of 28 checks passed
@GreatV GreatV mentioned this pull request Nov 17, 2023
Merged
@GreatV GreatV deleted the add_multigammaln_api branch November 17, 2023 10:52
@GreatV
Copy link
Contributor Author

GreatV commented Nov 17, 2023

中文文档PR

@GreatV GreatV mentioned this pull request Nov 24, 2023
Closed
26 tasks
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
@GreatV @sunzhongkai588 @SecretXV
【Hackathon 5th No.9】add multigammaln api -part (PaddlePaddle#57599)
eae3583 
* add multigammaln api

* fix PR-CI-Static-Check

* fix PR-CI-Static-Check

* fix PR-CI-Static-Check

* update

* fix bug

* add test_inplace

* fix bug

* fix bug

* fixed

* bug fixed

* update

* fix bug

* Update python/paddle/tensor/math.py

Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com>

---------

Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com>
@GreatV GreatV mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuxinyi389 xuxinyi389 xuxinyi389 left review comments

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

@jeff41404 jeff41404 jeff41404 left review comments

@luotao1 luotao1 Awaiting requested review from luotao1

@SigureMo SigureMo Awaiting requested review from SigureMo

Assignees

@luotao1 luotao1

@jeff41404 jeff41404

@sunzhongkai588 sunzhongkai588

@xuxinyi389 xuxinyi389

Labels
contributor External developers PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GreatV @luotao1 @xuxinyi389 @jeff41404 @SigureMo @sunzhongkai588