Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reused RawKernel in elementwise_kernel #57721

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

tianhaodongbd
Copy link
Contributor

PR types

Others

PR changes

OPs

Description

Pcard-70459
在 paddle/phi/kernels/legacy/elementwise_kernel.h 中复用RawKernel

@paddle-bot
Copy link

paddle-bot bot commented Sep 25, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -19,6 +19,13 @@

namespace phi {

template <typename T, typename Context>
void DivideRawKernel(const Context& dev_ctx,
const DenseTensor& x,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paddle/phi/kernels/impl/elementwise_kernel_impl.h
这个里面已经有DivideRaw 不需要这里再定义

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paddle/phi/kernels/impl/elementwise_kernel_impl.h 里没有DivideRaw的声明 如果去掉paddle/phi/kernels/legacy/elementwise_kernel.h里添加的声明 就没法编译过了

@AnnaTrainingG AnnaTrainingG merged commit bbd8ca4 into PaddlePaddle:develop Sep 28, 2023
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants