[PIR] Adapt paddle.assign to pir #57780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
Charles-hit
approved these changes
Sep 27, 2023
Aurelius84
approved these changes
Sep 27, 2023
| ) | ||
| dtype = core.DataType.FLOAT32 | ||
|
|
||
| if dtype == core.VarDesc.VarType.BOOL or dtype == core.DataType.BOOL: |
There was a problem hiding this comment.
Suggested change
| if dtype == core.VarDesc.VarType.BOOL or dtype == core.DataType.BOOL: | |
| if dtype in [core.VarDesc.VarType.BOOL, core.DataType.BOOL]: |
| _current_expected_place(), | ||
| ) | ||
| if in_dynamic_mode(): | ||
| _C_ops.assign_value_( |
There was a problem hiding this comment.
这里动态图下没有返回么？还是说其实返回了output本身。如果是后者的话，其实这里可以统一成一个分支？
There was a problem hiding this comment.
动态图没返回，因为是inplace的，而新IR下inplace是需要返回一个新value来表示的，故拆成俩个分支
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
* migrate assign * fix py3 bugs
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 16, 2023
* migrate assign * fix py3 bugs
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* migrate assign * fix py3 bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-67164
适配paddle.assign满足新ir