[PHI]Fix cub bugs when use PHI shared lib in CUDA12 #57820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
Sorry to inform you that 780e10f's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
zyfncg
reviewed
Oct 10, 2023
cmake/third_party.cmake
Outdated
| @@ -372,9 +372,12 @@ if(WITH_ONNXRUNTIME) | |||
| endif() | |||
|
|
|||
| if(WITH_GPU) | |||
| if(${CMAKE_CUDA_COMPILER_VERSION} LESS 11.0) | |||
| if(${CMAKE_CUDA_COMPILER_VERSION} LESS 11.1) | |||
There was a problem hiding this comment.
前面是11.0的版本，这里是11.1，前后版本不一致会不会有问题？
There was a problem hiding this comment.
理论上排除不了cuda11.0有问题的可能性，不过从之前cub.cmake中的代码中可以推断cuda11.6以下使用cub1.8.0问题应该不大，而且我们没有cuda11.0的流水线机器去测试，先把代码合入吧，后续有问题再进一步解决
There was a problem hiding this comment.
另外这里之所以改的原因是，cccl支持cuda11.1及以上版本
chenwhql
previously approved these changes
Oct 10, 2023
risemeup1
approved these changes
Oct 11, 2023
chenwhql
approved these changes
Oct 11, 2023
zyfncg
approved these changes
Oct 11, 2023
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
* fix cuda12 bugs * fix windows bugs * move cccl to third_party * perfect code * fix cuda bugs
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 16, 2023
* fix cuda12 bugs * fix windows bugs * move cccl to third_party * perfect code * fix cuda bugs
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* fix cuda12 bugs * fix windows bugs * move cccl to third_party * perfect code * fix cuda bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
Pcard-67164
修复在cuda12环境下使用phi动态库，三方库cub造成的reduce精度问题，修复方案是使用nvidia cccl代码库来替代cub，顺便优化了creation.py的部分代码