-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Hackathon 5th No.26】为 Paddle 新增 diagonal_scatter API -part #57879
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
Sorry to inform you that bab7de6's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
bab7de6
to
209bdda
Compare
@zxcd 辛苦review一下,diagonal_scatter的实现 |
@zxcd 修改完了,辛苦再review一下 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The logic of the |
|
Adding branch of static mode to the current API |
OK, you can add link of PR to the description above and add these tasks to rfc |
@jeff41404 cc @zxcd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…tensor for diagonal_scatter
Co-authored-by: ooo oo <106524776+ooooo-create@users.noreply.github.com>
Co-authored-by: ooo oo <106524776+ooooo-create@users.noreply.github.com>
6930362
to
bcda589
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其余LGTM @sunzhongkai588
Co-authored-by: ooo oo <106524776+ooooo-create@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @sunzhongkai588
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for docs
hi, @DanGuge
|
…ddle#57879) * add diagonal_scatter * add diagonal_scatter_test * add annotations * modify int32/int64 test range * update diagonal_scatter doc * fix: bfloat16 type & test name & LayerHelper position * add diagonal scatter in __all__ list * add int16 in fill_diagonal_tensor & reuse the logic of fill_diagonal_tensor for diagonal_scatter * remove xpu settings * op test get_numeric_gradient does not support int16 * fix * Update python/paddle/tensor/manipulation.py Co-authored-by: ooo oo <106524776+ooooo-create@users.noreply.github.com> * Update python/paddle/tensor/manipulation.py Co-authored-by: ooo oo <106524776+ooooo-create@users.noreply.github.com> * fix review suggestions * Update python/paddle/tensor/manipulation.py Co-authored-by: ooo oo <106524776+ooooo-create@users.noreply.github.com> * fix --------- Co-authored-by: ooo oo <106524776+ooooo-create@users.noreply.github.com>
PR types
Others
PR changes
Others
Description
为 Paddle 新增 diagonal_scatter API
RFC:PaddlePaddle/community#669
#57262