[VJP]Fix frobenius_norm bug and add to vjp list #57942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
YuanRisheng
approved these changes
Oct 19, 2023
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Oct 24, 2023
* fix frobenius_norm bug * recover yamls and move frobenius_norm to manual * fix and close new_ir * fix frobenius_norm * clean * add ReduceInferMetaBaseFN for frobenius_norm * clean * fix rename bug * clean * use ReduceIntArrayAxisInferMetaBase instead
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 26, 2023
* fix frobenius_norm bug * recover yamls and move frobenius_norm to manual * fix and close new_ir * fix frobenius_norm * clean * add ReduceInferMetaBaseFN for frobenius_norm * clean * fix rename bug * clean * use ReduceIntArrayAxisInferMetaBase instead
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* fix frobenius_norm bug * recover yamls and move frobenius_norm to manual * fix and close new_ir * fix frobenius_norm * clean * add ReduceInferMetaBaseFN for frobenius_norm * clean * fix rename bug * clean * use ReduceIntArrayAxisInferMetaBase instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
pcard-67164
由于frobenius_norm算子的yaml配置不统一，vjp代码生成部分会出现类型不匹配的问题。
尝试修改static部分的yaml为int64_t，但是会遇到CI拦截，因此只能修改legacy中的yaml配置。
同时调用的ReduceInferMeta函数也需要进行对应的类型修改，如果在原本的ReduceInferMetaBase上直接修改会给其他调用此函数的reduce_any和reduce_all带来新的问题。于是将infermeta函数修改为ReduceIntArrayAxisInferMetaBase。