Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish mp async allreduce implementation. #57965

Merged

Conversation

GhostScreaming
Copy link
Contributor

@GhostScreaming GhostScreaming commented Oct 9, 2023

PR types

Performance optimization

PR changes

Others

Description

PCard-70444

Remove paddle.ones as PR 57574 has fixed mp aysnc allreduce overlap failure.

@paddle-bot
Copy link

paddle-bot bot commented Oct 9, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 是不是在哪里加个warning比较好?

Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GhostScreaming GhostScreaming merged commit 5934ef9 into PaddlePaddle:develop Oct 11, 2023
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
* Remove paddle.ones as PR 57574 has fixed mp aysnc allreduce overlap failure

* Add warnings for mp async all_reduce when CUDA_DEVICE_MAX_CONNECTIONS is unset.
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
* Remove paddle.ones as PR 57574 has fixed mp aysnc allreduce overlap failure

* Add warnings for mp async all_reduce when CUDA_DEVICE_MAX_CONNECTIONS is unset.
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* Remove paddle.ones as PR 57574 has fixed mp aysnc allreduce overlap failure

* Add warnings for mp async all_reduce when CUDA_DEVICE_MAX_CONNECTIONS is unset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants