Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PIR] Add ExpandShapeOfOpPattern and complete patternMatch #58036

Merged
merged 11 commits into from
Oct 25, 2023
Merged

[PIR] Add ExpandShapeOfOpPattern and complete patternMatch #58036

merged 11 commits into from
Oct 25, 2023

Conversation

zhangbopd
Copy link
Contributor

@zhangbopd zhangbopd commented Oct 12, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

  • 新增 isIndex、earse、use_empty 方法
  • 新增 OneResultTrait
  • OP trait 使用 anonymous namesapce
  • 完善 patternMatch 中的 Todo(wilber)
  • 新增 ExpandShapeOfOpPattern
  • 规范之前 PR 的变量命名、以及 comment ( assert->IR_ENFORCE 等等
  • Shape Dialect 中新增 ShapeOfOP、 FromElementsOp

Other

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Oct 12, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhangbopd zhangbopd changed the title isIndex earse use_empty、oneResultTrait anonymousNamesapce patternMatch [PIR] Add ExpandShapeOfOpPattern and complete patternMatch Oct 12, 2023
@zhangbopd zhangbopd requested review from Aurelius84, zhangbo9674 and winter-wang and removed request for Aurelius84 October 18, 2023 12:51
Aurelius84
Aurelius84 reviewed Oct 19, 2023
View reviewed changes
paddle/pir/core/builtin_attribute.h Show resolved Hide resolved
paddle/pir/core/infer_type_op_interface.h Outdated Show resolved Hide resolved
paddle/pir/core/infer_type_op_interface.h Outdated Show resolved Hide resolved
paddle/pir/core/infer_type_op_interface.h Outdated Show resolved Hide resolved
paddle/pir/core/op_trait.h Show resolved Hide resolved
paddle/pir/core/operation.cc Outdated Show resolved Hide resolved
paddle/pir/core/operation.cc Show resolved Hide resolved
@zhangbopd zhangbopd requested review from winter-wang, Aurelius84, XiaoguangHu01 and lanxianghit and removed request for zhangbo9674 October 24, 2023 08:56
lanxianghit
lanxianghit approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangbopd zhangbopd merged commit d81d983 into PaddlePaddle:develop Oct 25, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@zhangbopd
[PIR] Add ExpandShapeOfOpPattern and complete patternMatch (PaddlePad…
84e8b05 
…dle#58036)

* isIndex earse use_empty、oneResultTrait anonymousNamesapce patternMatch

* put template member func in .h rather than .cc

* add test_pir_utils and rename SymbolicDim

* indexAttribute、More shape ops、InferShapedTypeOpInterface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@lanxianghit lanxianghit lanxianghit approved these changes

@winter-wang winter-wang Awaiting requested review from winter-wang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhangbopd @Aurelius84 @XiaoguangHu01 @lanxianghit @winter-wang