-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PIR] Reconstruct the Verify system #58052
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
void IfOp::Verify() {} | ||
void IfOp::Verify() { | ||
if ((*this)->region(0).empty() && (*this)->region(1).empty()) { | ||
LOG(WARNING) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
现在operation::create里面是调用了verify函数的。而create的时候,region都是空的。也就是说这个warning是一定会进入的。
return; | ||
} | ||
|
||
PADDLE_ENFORCE_EQ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true_region和false_region的size可以不相等。
true_region的size一定等于1。 如果输入为空,false_region的size可以为0, 否则,一定为1;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* refine verify of if op * fix * fix * fix * refine * fix * fix * fix * fix
* refine verify of if op * fix * fix * fix * refine * fix * fix * fix * fix
* refine verify of if op * fix * fix * fix * refine * fix * fix * fix * fix
PR types
New features
PR changes
Others
Description
针对多 region 场景,重构 PIR 的 Verify 体系,重构背景如下:
重构前后 Verify 体系的变化:
重构后,算子的校验将分为两个维度:Verify = VerifySig + VerifyRegion
应用方法:
Pcard-67164