Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR] Migrate paddle.sin into pir #58094

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

MarioLulab
Copy link
Contributor

@MarioLulab MarioLulab commented Oct 14, 2023

PR types

Others

PR changes

Others

Description

新 IR API 推全升级
paddle.sin 迁移升级至 new ir,并更新单测

单测覆盖率:6/8

备注:目前缺少适配 test/legacy_test/test_activation_nn_grad.pyTestSinDoubleGradCheckTestSinTripleGradCheck 的单测,原因是当前不支持 gradient_checker.double_grad_checkgradient_checker.triple_grad_check 在 pir 体系下运行,具体的适配问题包括但不限于:目前缺少从 python 端获取 OpResult.name 的支持 ...

后续做自动微分推全工作的时候,可以进行支持

Copy link
Contributor

@0x45f 0x45f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit 4e1270d into PaddlePaddle:develop Oct 17, 2023
@MarioLulab MarioLulab deleted the luqi/pir_api_sin branch October 17, 2023 03:09
hitywt pushed a commit to hitywt/Paddle that referenced this pull request Oct 24, 2023
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 26, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants