[PIR] lowering group op through op fusion && fusion merge pass and kernel jit pass #58193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test_pir_cinn_softmax
… test_pir_cinn_softmax
… test_pir_cinn_softmax
… test_pir_cinn_softmax
… test_pir_cinn_softmax
… test_pir_cinn_softmax
…e/Paddle into connect_softmax_all_path
… connect_softmax_all_path
… connect_softmax_all_path
… connect_softmax_all_path
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
… connect_softmax_all_path
… connect_softmax_all_path
… connect_softmax_all_path
phlrain
changed the title
phlrain
changed the title
… connect_softmax_all_path
… connect_softmax_all_path
zhangbo9674
approved these changes
Oct 23, 2023
Aurelius84
approved these changes
Oct 23, 2023
| namespace ir { | ||
|
|
||
| std::vector<pir::Value> GetBlockOutsideInput( | ||
| const std::vector<pir::Operation*> op_list) { |
There was a problem hiding this comment.
Suggested change
| const std::vector<pir::Operation*> op_list) { | |
| const std::vector<pir::Operation*>& op_list) { |
| } | ||
|
|
||
| std::vector<pir::Value> GetBlockOutsideOutput( | ||
| const std::vector<pir::Operation*> op_list) { |
There was a problem hiding this comment.
Suggested change
| const std::vector<pir::Operation*> op_list) { | |
| const std::vector<pir::Operation*>& op_list) { |
| "Only support one group after group fusion")); | ||
| for (auto group : group_list) { | ||
| auto ir_compiler = | ||
| new cinn::hlir::framework::PIRCompiler(*program, target, scope); |
There was a problem hiding this comment.
这里会有潜在的mem leak风险，如之前讨论，我们还没有确定最终如何统一管理PIRCompiler 对象，但可以先简单地用单例持有下，这样能保证退出后可以delete掉这个new的对象
| return vec_res; | ||
| } | ||
|
|
||
| std::unique_ptr<pir::Program> CINNGroupLoweringPass(::pir::Program* program) { |
There was a problem hiding this comment.
Suggested change
| std::unique_ptr<pir::Program> CINNGroupLoweringPass(::pir::Program* program) { | |
| std::unique_ptr<pir::Program> CINNGroupLoweringPass(const ::pir::Program* program) { |
这里可以const一下？
| @@ -61,9 +61,11 @@ std::vector<pir::CUDAJITInfo> PIRCompiler::BuildCUDAJITInfo( | |||
|
|
|||
| auto fn_ptrs = compiler_->GetFnPtr(); | |||
|
|
|||
| auto* compilter_ptr = compiler_.release(); | |||
There was a problem hiding this comment.
这里release后，jit.info是不是仅持有了指向资源的指针，但其实没有负责析构（即delete）它？
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Oct 24, 2023
…rnel jit pass (PaddlePaddle#58193) * update * update * revert some code * update * poish print * fix compile bug * update * update * polish code * update * update * update * update * update * remove useless code * remove useless code * remove useless code * fix compile bug
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 26, 2023
…rnel jit pass (PaddlePaddle#58193) * update * update * revert some code * update * poish print * fix compile bug * update * update * polish code * update * update * update * update * update * remove useless code * remove useless code * remove useless code * fix compile bug
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
…rnel jit pass (PaddlePaddle#58193) * update * update * revert some code * update * poish print * fix compile bug * update * update * polish code * update * update * update * update * update * remove useless code * remove useless code * remove useless code * fix compile bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Description
TODO：
当前group中的input 和output 存在问题，pr中进行了限制，会在新PR中进行优化
Pcard-67164