[PIR] separate the translation context between different blocks #58198
+134
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
winter-wang
reviewed
Oct 18, 2023
| @@ -243,12 +246,13 @@ const TCValue& TranslationContext::at(const TCKey& key) const { | |||
| size_t TranslationContext::count(const TCKey& key) const { | |||
| auto it = container_.find(key); | |||
| if (it == container_.end()) { | |||
| if (parent_) return parent_->count(key); | |||
| return 0u; | |||
| } | |||
| const auto& values = it->second; | |||
| PADDLE_ENFORCE_NE( | |||
There was a problem hiding this comment.
Suggested change
| PADDLE_ENFORCE_NE( | |
| PADDLE_ENFORCE(!value.empty(), |
zhangbo9674
approved these changes
Oct 18, 2023
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Oct 24, 2023
…lePaddle#58198) * seperate the translation context bewteen different blocks * remove debug code * remove debug code
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 26, 2023
…lePaddle#58198) * seperate the translation context bewteen different blocks * remove debug code * remove debug code
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
…lePaddle#58198) * seperate the translation context bewteen different blocks * remove debug code * remove debug code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
To separate the translation context between different blocks, we modify TranslationContext to a tree like data structure. When translating a block, one should be careful about the translation context used.
Others
Pcard-67164