Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 5th No.13】【关联 PR】Added int support for sign -Part #58255

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

PommesPeter
Copy link
Contributor

@PommesPeter PommesPeter commented Oct 19, 2023

PR types

Others

PR changes

Others

Description

reference link: #57882 (comment)

已完成,可 review

改动简介:

  1. 对 SignKernel 增加 int 类型 (included CPU and GPU)
  2. 修改单测,删除有关 sign 遇到 int 类型抛出错误的样例,添加 sign 对 int 类型的结果测试

@paddle-bot
Copy link

paddle-bot bot commented Oct 19, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 19, 2023
@PommesPeter
Copy link
Contributor Author

之前那个分支不小心混了其他分支的代码,以此 pr 为准,麻烦涛姐重新 assign 一下 @luotao1

sunzhongkai588

This comment was marked as spam.

Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 请中文文档也同步增加修改 @PommesPeter

@luotao1 luotao1 changed the title 【Hackathon 5th No.13】【关联 PR】Added int support for sign 【Hackathon 5th No.13】【关联 PR】Added int support for sign -Part Oct 20, 2023
@luotao1 luotao1 merged commit 245046a into PaddlePaddle:develop Oct 20, 2023
@PommesPeter
Copy link
Contributor Author

中文文档已提 PR,PaddlePaddle/docs#6235

hitywt pushed a commit to hitywt/Paddle that referenced this pull request Oct 24, 2023
…addle#58255)

* ♻️ Refactor: added sign int type support

* ✏️ Refactor: update typo
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 26, 2023
…addle#58255)

* ♻️ Refactor: added sign int type support

* ✏️ Refactor: update typo
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
…addle#58255)

* ♻️ Refactor: added sign int type support

* ✏️ Refactor: update typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants