fix randint op #58295
Merged
fix randint op #58295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
kangguangli
reviewed
Oct 31, 2023
| paddle::framework::proto::VarType::Type var_type = | ||
| static_cast<paddle::framework::proto::VarType::Type>(dtype_num); | ||
|
|
||
| pir::Type dtype = type_translator.operator[](var_type)(ctx, *var); |
There was a problem hiding this comment.
Suggested change
| pir::Type dtype = type_translator.operator[](var_type)(ctx, *var); | |
| pir::Type dtype = type_translator[var_type](ctx, *var); |
这行应该可以这样？
另外，输出类型的翻译过程能否优化为
pir::Type translated_var_type = type_translator[VarType::LOD_TENSOR](ctx, *var);
There was a problem hiding this comment.
已修改为
pir::Type dtype = type_translator[var_type](ctx, *var);这里主要是要翻译的LOD_TENSOR的dtype类型会出现RAW类型，直接调用type_translator[VarType::LOD_TENSOR](ctx, *var)的话，会调用对应的函数翻译RAW类型，但是目前不支持RAW类型的翻译，所以这里仿照InferMeta的逻辑，将attribute中的dtype指定给Out
| "[op:%s] Output %s should not be null", | ||
| op_desc.Type(), | ||
| var_name); | ||
| int dtype_num = PADDLE_GET_CONST(int, op_desc.GetAttr("dtype")); |
There was a problem hiding this comment.
不建议叫dtype_num。另外dtype是属性，但是VarDesc中也有dtype字段，没有特殊情形用VarDesc里的dtype就可以了吧，不建议在这里做额外的工作。
There was a problem hiding this comment.
已修改dtype_num为dtype_attr_val。如果直接使用VarDesc里的dtype会遇到翻译RAW类型的情况
xingmingyyj
force-pushed
the
fix_randint_op
branch
from
2dd4f12
to
46946a9
Compare
xingmingyyj
force-pushed
the
fix_randint_op
branch
from
f017d3f
to
51de5d4
Compare
kangguangli
approved these changes
Nov 7, 2023
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Nov 7, 2023
* fix randint op * Update new_ir_op_test_no_check_list * fix name * fix file name * fix file name * Update pir_op_test_no_check_list
zeroRains
pushed a commit
to zeroRains/Paddle
that referenced
this pull request
Nov 8, 2023
* fix randint op * Update new_ir_op_test_no_check_list * fix name * fix file name * fix file name * Update pir_op_test_no_check_list
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* fix randint op * Update new_ir_op_test_no_check_list * fix name * fix file name * fix file name * Update pir_op_test_no_check_list
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* fix randint op * Update new_ir_op_test_no_check_list * fix name * fix file name * fix file name * Update pir_op_test_no_check_list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
fix randint op