Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR] Migrate paddle.nn.LeakyReLU into pir #58340

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

MarioLulab
Copy link
Contributor

@MarioLulab MarioLulab commented Oct 24, 2023

PR types

Others

PR changes

Others

Description

PIR API 推全升级
将 paddle.nn.LeakyReLU 迁移升级至 pir,并更新单测 本 pr 进行补充.
paddle.nn.LeakyReLU 中包含 paddle.nn.functional.leaky_relu 调用,故一起进行适配.

单测覆盖率:8/10

TODO:

  1. 目前缺少适配 test/legacy_test/test_activation_nn_grad.py 内 TestLeakyReluDoubleGradCheck
  2. test/mkldnn/test_activation_bf16_mkldnn_op.py 内的 TestMKLDNNLeakyReluBF16Op 未适配,因为目前 PIR 不支持算子带有 mkldnn 属性

@paddle-bot
Copy link

paddle-bot bot commented Oct 24, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 24, 2023
@paddle-bot
Copy link

paddle-bot bot commented Oct 24, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@MarioLulab MarioLulab marked this pull request as draft October 24, 2023 11:10
@MarioLulab MarioLulab marked this pull request as ready for review October 25, 2023 02:21
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit b4b8337 into PaddlePaddle:develop Oct 25, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants