Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ BugFix] fix is_test memory problem #58350

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

2742195759
Copy link
Contributor

@2742195759 2742195759 commented Oct 24, 2023

PR types

Bug fixes

PR changes

Others

Description

fix is_test memory problem
原来的动转静没有完全考虑到 is_test 和 HasGrad 的情况。使用了need_grad 来合并重复的bool表达式。

PCard-66972

@paddle-bot
Copy link

paddle-bot bot commented Oct 24, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 25, 2023
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

bool in_forward_block = forward_global_block.HasVar(name);
bool in_backward_block =
backward_global_block && backward_global_block->HasVar(name);
backward_global_block && backward_global_block->HasVar(name);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这条语句是有用的嘛?

@2742195759 2742195759 merged commit 06f5086 into PaddlePaddle:develop Nov 1, 2023
@2742195759 2742195759 deleted the fix-dy2static-memory branch November 1, 2023 06:25
@paddle-bot paddle-bot bot removed the contributor External developers label Nov 3, 2023
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
* fix is_test memory problem/

* fix bugs

* fix

* fix variable not found error, just emit it.
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* fix is_test memory problem/

* fix bugs

* fix

* fix variable not found error, just emit it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants