Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PIR]Migrate Conv3D into pir #58418

Merged
merged 1 commit into from
Oct 30, 2023
Merged

[PIR]Migrate Conv3D into pir #58418

merged 1 commit into from
Oct 30, 2023

Conversation

0x45f
Copy link
Contributor

@0x45f 0x45f commented Oct 26, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

[PIR]Migrate Conv3D into pir
涉及两个单测文件：

  • test_conv3d_op.py: 继承自TestCase的单测内因为使用了paddle.static.nn.conv3d，静态图专用的api没有适配，所以这类单测没有打开，其他继承自OpTest的单测都已经打开了
  • test_conv3d_layer.py: 新增了一个pir的测试case，原有测试case没有打开

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Oct 26, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 26, 2023
Aurelius84
Aurelius84 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlrain phlrain self-requested a review October 30, 2023 07:05
@0x45f 0x45f merged commit dd1fa3c into PaddlePaddle:develop Oct 30, 2023
@0x45f 0x45f deleted the pir-Conv3D branch October 30, 2023 07:11
@paddle-bot paddle-bot bot removed the contributor External developers label Nov 3, 2023
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
@0x45f @zeroRains
[PIR]Migrate Conv3D into pir (PaddlePaddle#58418)
4932795
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@0x45f
[PIR]Migrate Conv3D into pir (PaddlePaddle#58418)
29445e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@phlrain phlrain phlrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x45f @Aurelius84 @phlrain