Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dy2St] Refactor dy2st unittest decorators name - Part 4 #58465

Merged
merged 3 commits into from
Oct 29, 2023
Merged

[Dy2St] Refactor dy2st unittest decorators name - Part 4 #58465

merged 3 commits into from
Oct 29, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Oct 28, 2023

@paddle-bot
Copy link

paddle-bot bot commented Oct 28, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@gouzil gouzil mentioned this pull request Oct 28, 2023
Closed
@paddle-bot paddle-bot bot added the contributor External developers label Oct 28, 2023
@gouzil gouzil changed the title [Dy2St] Refactor dy2st unittest decorators name - Part 4 [WIP][Dy2St] Refactor dy2st unittest decorators name - Part 4 Oct 29, 2023
SigureMo
SigureMo reviewed Oct 29, 2023
View reviewed changes
test/dygraph_to_static/test_return.py Outdated
@@ -351,7 +350,7 @@ def init_dygraph_func(self):
self.dygraph_func = test_return_in_while_2
self.error = "Found return statement in While or For body and loop"

@ast_only_test
@test_ast_only
def test_transformed_static_result(self):
super().test_transformed_static_result()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

这写法没必要吧，test_transformed_static_result 都被删了当然没有，默认继承也可以自动调用，没必要写这个函数，删掉吧，下同

SigureMo
SigureMo reviewed Oct 29, 2023
View reviewed changes
test/dygraph_to_static/test_return.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看了一下，这个文件没必要测 sot，直接在基类上装饰 test_ast_only 即可，没必要 x2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前的想法应该是只有部分case想跑ast

Copy link
Member

@SigureMo SigureMo Oct 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to_static 已经传入 full_graph=True 了，只能跑 AST，即便开启 SOT 也是无效的，参数优先级高于环境变量

@gouzil gouzil changed the title [WIP][Dy2St] Refactor dy2st unittest decorators name - Part 4 [Dy2St] Refactor dy2st unittest decorators name - Part 4 Oct 29, 2023
SigureMo
SigureMo approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@SigureMo SigureMo merged commit 431403f into PaddlePaddle:develop Oct 29, 2023
28 checks passed
This was referenced Oct 30, 2023
Merged
Merged
Merged
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
@gouzil @zeroRains
[Dy2St] Refactor dy2st unittest decorators name - Part 4 (PaddlePaddl…
f8ae9fa 
…e#58465)
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@gouzil
[Dy2St] Refactor dy2st unittest decorators name - Part 4 (PaddlePaddl…
367749c 
…e#58465)
@gouzil gouzil deleted the dy2st_unittest_rename_decorator_4 branch December 27, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gouzil @SigureMo