[PIR][AutoParallel] Support merge fetch results among micro_scopes #58528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyinglia
changed the title
zhaoyinglia
changed the title
added 2 commits
November 1, 2023 17:30
From00
previously approved these changes
Nov 2, 2023
| Scope* scope, | ||
| FetchUnmergedList* fetch_list); | ||
|
|
||
| void MergeFetchTensors(const FetchUnmergedList& fetch_list, |
There was a problem hiding this comment.
Suggested change
| void MergeFetchTensors(const FetchUnmergedList& fetch_list, | |
| void MergeFetchList(const FetchUnmergedList& fetch_list, |
| @@ -71,11 +54,17 @@ class Job final { | |||
| skip_gc_vars_ = skip_gc_vars; | |||
| } | |||
|
|
|||
| void SetFetchVarName(std::string fetch_var_name) { | |||
There was a problem hiding this comment.
Suggested change
| void SetFetchVarName(std::string fetch_var_name) { | |
| void SetFetchVarName(const std::string& fetch_var_name) { |
| if (need_fetch) { | ||
| for (auto& var_name : fetch_var_names_) { | ||
| auto* var = inner_scope->FindVar(var_name); | ||
| VLOG(0) << "fetch " << var_name << "[" << var << "]"; |
There was a problem hiding this comment.
Suggested change
| VLOG(0) << "fetch " << var_name << "[" << var << "]"; | |
| VLOG(6) << "fetch " << var_name << "[" << var << "]"; |
| feed_names[i], | ||
| numel_size, | ||
| micro_batch_num)); | ||
| int64_t split_size = (numel_size + micro_batch_num - 1) / micro_batch_num; |
There was a problem hiding this comment.
Suggested change
| int64_t split_size = (numel_size + micro_batch_num - 1) / micro_batch_num; | |
| int64_t split_size = numel_size / micro_batch_num; |
| VLOG(4) << "Split feed data:" << feed_names[i] << ", dims:(" | ||
| << feed_tensor.dims() << "), micro_batch_num:" << micro_batch_num; | ||
| for (int64_t j = 0; j < micro_batch_num; ++j) { | ||
| (*out)[j].resize(i + 1); |
There was a problem hiding this comment.
可以直接分配feed_tensors.size个元素空间
| FetchList* out); | ||
|
|
||
| void MergeTensors(const std::vector<const phi::DenseTensor*>& tensors, | ||
| platform::Place dst_place, |
There was a problem hiding this comment.
Suggested change
| platform::Place dst_place, | |
| const platform::Place& dst_place, |
From00
approved these changes
Nov 3, 2023
zeroRains
pushed a commit
to zeroRains/Paddle
that referenced
this pull request
Nov 8, 2023
…addlePaddle#58528) * [PIR][AutoParallel] Support MicroScope Merge Fetch Result * fix func name * revert plan * fix feed * tiny fix * rm print&update ut * rm comment * fix splitfeed & ut * add mergetensor func * fix ut * update split_size
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
…addlePaddle#58528) * [PIR][AutoParallel] Support MicroScope Merge Fetch Result * fix func name * revert plan * fix feed * tiny fix * rm print&update ut * rm comment * fix splitfeed & ut * add mergetensor func * fix ut * update split_size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-76459
FetchTensorsto get all multi-scope fetch resultsMergeFetchTensorsto merge fetch results of the same name and different scope