Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dy2St] Cleanup useless attr double_grads #58547

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Oct 31, 2023

PR types

Others

PR changes

Others

Description

清理无用的 _double_grads,这个在 #51693 置为恒 None 了,但一直没有清理相关使用的地方

PCard-66972

@SigureMo SigureMo changed the title [Dy2St] Cleanup useless attr double_grads [Dy2St] Cleanup useless attr double_grads Oct 31, 2023
@paddle-bot paddle-bot bot added the contributor External developers label Oct 31, 2023
2742195759
2742195759 previously approved these changes Nov 1, 2023
Copy link
Contributor

@2742195759 2742195759 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Nov 1, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Nov 1, 2023
@SigureMo SigureMo closed this Nov 1, 2023
@SigureMo SigureMo reopened this Nov 1, 2023
@SigureMo SigureMo merged commit 4ccb9d2 into PaddlePaddle:develop Nov 1, 2023
28 checks passed
@SigureMo SigureMo deleted the dy2st/cleanup-double-grads branch November 1, 2023 16:37
@paddle-bot paddle-bot bot removed the contributor External developers label Nov 3, 2023
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants