Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prim][PIR] softmax forward sink #58591

Merged
merged 11 commits into from
Nov 13, 2023

Conversation

kevincheng2
Copy link
Contributor

PR types

New features

PR changes

Others

Description

softmax forward op sink to c++

@paddle-bot paddle-bot bot added the contributor External developers label Nov 1, 2023
@@ -248,7 +248,7 @@ def silu(x):
return res if not is_amp else cast(res, dtype)


@register_decomp('pd_op.softmax')
# @register_decomp('pd_op.softmax')
def softmax(x, axis):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下沉无误后这里可以删掉了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

Copy link
Contributor

@cyber-pioneer cyber-pioneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyber-pioneer cyber-pioneer merged commit cade1d5 into PaddlePaddle:develop Nov 13, 2023
28 checks passed
@luotao1
Copy link
Contributor

luotao1 commented Nov 14, 2023

hi, @kevincheng2

  • 非常感谢你对飞桨框架的贡献,我们正在运营一个PFCC组织,会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨框架做贡献,详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣,请发送邮件至 ext_paddle_oss@baidu.com,我们会邀请你加入~

danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* relu forward sink

* softmax sink pir

* remove relu

* pir relu sink

* remove softmax register

* remove python softmax

* update code

* merge code

---------

Co-authored-by: kevincheng2 <cheng112@gmail.com>
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
* relu forward sink

* softmax sink pir

* remove relu

* pir relu sink

* remove softmax register

* remove python softmax

* update code

* merge code

---------

Co-authored-by: kevincheng2 <cheng112@gmail.com>
@kevincheng2 kevincheng2 deleted the softmax_prim_pir branch January 5, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants