[AutoParallel] tensor.cc support auto parallel #58656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
YuanRisheng
previously approved these changes
Nov 6, 2023
paddle/phi/api/lib/tensor.cc
Outdated
| @@ -213,6 +217,10 @@ T *Tensor::mutable_data() { | |||
| if (is_dense_tensor()) { | |||
| return static_cast<phi::DenseTensor *>(impl_.get()) | |||
| ->mutable_data<T>(place()); | |||
| } else if (is_dist_tensor()) { | |||
| return static_cast<phi::distributed::DistTensor *>(impl_.get()) | |||
There was a problem hiding this comment.
欢哥，unsafe_mutable_value()会直接修改DistTensor的local value，应该尽可能的少使用，必须要使用的地方建议用VLOG打印一些调试信息，不然之后debug会困难
paddle/phi/api/lib/tensor.cc
Outdated
| @@ -274,6 +286,10 @@ template <typename T> | |||
| const T *Tensor::data() const { | |||
| if (is_dense_tensor()) { | |||
| return static_cast<phi::DenseTensor *>(impl_.get())->data<T>(); | |||
| } else if (is_dist_tensor()) { | |||
| return static_cast<phi::distributed::DistTensor *>(impl_.get()) | |||
| ->unsafe_mutable_value() | |||
There was a problem hiding this comment.
这一类建议用static_cast<phi::distributed::DistTensor *>(impl_.get())->value()->data<T>()，尽可能少开放直接修改DistTensor的接口
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Nov 7, 2023
* tensor.cc support auto parallel
zeroRains
pushed a commit
to zeroRains/Paddle
that referenced
this pull request
Nov 8, 2023
* tensor.cc support auto parallel
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* tensor.cc support auto parallel
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* tensor.cc support auto parallel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
tensor.cc支持AutoParallel
Pcard-73145