[Reshard] Support partial to shard #58703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiYuRio
force-pushed
the
dev_p_to_s
branch
8 times, most recently
from
c9d5b45 to
90032b3
Compare
ForFishes
reviewed
Nov 8, 2023
| if (out_split_axis != 0) { | ||
| std::vector<int> axis; | ||
| for (size_t i = 1; i < vectorize(logical_ddim).size(); ++i) { | ||
| axis.emplace_back(i); |
There was a problem hiding this comment.
Whether the axis here is the same as the previous one, no additional calculation is required.
There was a problem hiding this comment.
Excellent! You are totally right!
XieYunshen
approved these changes
Nov 9, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
支持partial状态到shard状态的转换
Pcard-73145