Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][Hackathon 5th No.49][pir] add OpResult.__setitem__ - Part 5 #58739

Closed
wants to merge 7 commits into from

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Nov 6, 2023

PR types

Others

PR changes

Others

Description

本pr主要是适配OpResult.__setitem__

(只支持了一个简单写法,更复杂的写法还是会引发段错误)

注:为什么不直接使用paddle._C_ops.set_value_替换paddle._legacy_C_ops.set_value_?

因为会在test/legacy_test/test_set_value_op.pyTestGradientTruncated.set_value引发段错误, 暂时还没排查到原因

TODO: 在Parse valuesOpResult进行处理

相关链接:

@0x45f
Copy link
Contributor

0x45f commented Nov 13, 2023

对于老静态图下的Variable的getitem和setitem里面会调用cond,目前新IR下还没有支持控制流cond。所以对于OpResult的getitem和setitem我们内部需要再讨论下如何实现~

…titem

# Conflicts:
#	python/paddle/base/variable_index.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants