[Inference] Support constant_folding_pass on PIR #58753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanlehome
changed the title
yuanlehome
changed the title
yuanlehome
force-pushed
the
shadow_output_op
branch
from
860d464 to
a30a22a
Compare
| pir::Program* new_program) const { | ||
| pir::Builder builder = pir::Builder(ir_context(), new_program->block()); | ||
| std::string output_var_name = | ||
| "constant_folding@" + std::to_string((*counter_)++); |
There was a problem hiding this comment.
用counter做唯一标识输出var name感觉不是很安全
There was a problem hiding this comment.
下面还有操作，拼接了被折叠掉的name
There was a problem hiding this comment.
提醒了我，这里有个潜在问题，随着折叠的深度，name拼接后会越来越长，我修一下
zyfncg
reviewed
Nov 8, 2023
Comment on lines
+1130
to
+1138
| // pm.EnableIRPrinting(std::make_unique<pir::PassManager::IRPrinterOption>( | ||
| // [](pir::Pass *pass, pir::Operation *op) { | ||
| // return pass->name() == "constant_folding_pass"; | ||
| // }, | ||
| // [](pir::Pass *pass, pir::Operation *op) { | ||
| // return pass->name() == "constant_folding_pass"; | ||
| // }, | ||
| // true, | ||
| // true)); |
zyfncg
reviewed
Nov 8, 2023
你说旧IR的实现吧，这比起来其实没有意义，旧模型转换到pir模型后，总op数量和被折叠的数量都不一样。算一下旧的折叠率的话，37% |
从op数量看这个数据确实意义不大，我刚才把折叠率理解成权重数量在折叠前后的对比，新旧IR的权重数量是一致的，如果折叠逻辑对齐的话折叠掉的参数数量应该是相同的，在不相同的时候这里数据或许一定的参考价值。 |
zyfncg
reviewed
Nov 8, 2023
| auto* param_var = scope_->FindVar(param_name); | ||
| PADDLE_ENFORCE_NOT_NULL( | ||
| param_var, | ||
| phi::errors::InvalidArgument("Parameter var not in scope.")); | ||
| deleted_vars_->push_back(param_name); |
yuanlehome
force-pushed
the
shadow_output_op
branch
from
32c5076 to
b4e4a1c
Compare
zyfncg
approved these changes
Nov 9, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* fix shadow_output_op * update * rewrite constant_folding_pass * update * update * fix compile * fix dce * enhance judgement
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* fix shadow_output_op * update * rewrite constant_folding_pass * update * update * fix compile * fix dce * enhance judgement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
Others
Description
前置PR: #58732
针对PIR，实现常量折叠pass并在swintransformer模型上跑通：
TODO:
Others
Pcard-71500