[SOT][3.11] Do not restore KW_NAMES + PRECALL in 3.11
#59017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2742195759
reviewed
Nov 15, 2023
|
|
||
| for instr in origin_instr[0:instr_idx]: | ||
| restroe_instrs = origin_instrs[:instr_idx] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
在发生 call breakgraph 时，不应该恢复已经执行过的序列中最后的 KW_NAMES + PRECALL，因为 KW_NAMES 是一个有副作用的字节码，会在后面需要的时候恢复，如果在开始就直接恢复会导致影响后面的 CALL，而 PRECALL 直接不用恢复，因为 PRECALL 的作用在模拟执行的时候就生效了，不需要生成字节码来实现
因此按照 trailing KW_NAMES + PRECALL pattern 来匹配，若匹配则删掉它们
PCard-66972