Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoParallel] Remove value for rank not in mesh #59060

Merged
merged 1 commit into from
Nov 21, 2023
Merged

[AutoParallel] Remove value for rank not in mesh #59060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 10 additions & 17 deletions paddle/phi/core/distributed/auto_parallel/dist_tensor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,12 @@ DistTensor::DistTensor() : value_(std::make_shared<DenseTensor>()) {}

DistTensor::DistTensor(const std::shared_ptr<phi::DenseTensor>& global_value,
const TensorDistAttr& dist_attr)
: dims_(global_value->dims()),
dist_attr_(dist_attr),
value_(std::make_shared<DenseTensor>()) {
: dims_(global_value->dims()), dist_attr_(dist_attr) {
// If the current rank doesn't in process_mesh, we should create an
// uninitialized tensor only with tensor_meta.
if (IsCurRankInMesh(dist_attr.process_mesh())) {
if (!dist_attr.is_replicated()) {
value_ = std::make_shared<DenseTensor>();
// 1. create replicated global tensor
TensorDistAttr replicated_dist_attr(vectorize(global_value->dims()));
replicated_dist_attr.set_process_mesh(dist_attr.process_mesh());
Expand All @@ -57,21 +56,16 @@ DistTensor::DistTensor(const std::shared_ptr<phi::DenseTensor>& global_value,
value_ = global_value;
}
} else {
// TODO(liyurui): The following logic is illegal, and should be removed
// later. It exist temporary because the basic execution procedure is not
// ready, even sometimes we try to construct a DistTensor with empty
// DistAttr. Here we warning when the DistAttr is empty for debug use.
if (dist_attr.empty()) {
LOG(WARNING) << "Try to construct a dist tensor with empty dist attr.";
}
value_ = global_value;
value_ = std::make_shared<DenseTensor>(
std::make_shared<phi::Allocation>(nullptr, 0, global_value->place()),
phi::DenseTensorMeta(global_value->meta()));
}
}

DistTensor::DistTensor(const std::shared_ptr<phi::DenseTensor>& global_value,
const ProcessMesh& process_mesh,
const Placements& placements)
: dims_(global_value->dims()), value_(std::make_shared<DenseTensor>()) {
: dims_(global_value->dims()) {
dist_tensor_meta_ = DistTensorMeta(
process_mesh,
placements,
Expand All @@ -88,6 +82,7 @@ DistTensor::DistTensor(const std::shared_ptr<phi::DenseTensor>& global_value,
// uninitialized tensor only with dist_tensor_meta_.
if (IsCurRankInMesh(process_mesh)) {
if (!dist_tensor_meta_.is_replicated()) {
value_ = std::make_shared<DenseTensor>();
// 1. create replicated global tensor
TensorDistAttr replicated_dist_attr(vectorize(global_value->dims()));
replicated_dist_attr.set_process_mesh(process_mesh);
Expand All @@ -101,11 +96,9 @@ DistTensor::DistTensor(const std::shared_ptr<phi::DenseTensor>& global_value,
value_ = global_value;
}
} else {
// The following logic is illegal, and should be removed
// later. It exist temporary because the basic execution procedure is not
// ready, even sometimes we try to construct a DistTensor with empty
// DistAttr. Here we warning when the DistAttr is empty for debug use.
value_ = global_value;
value_ = std::make_shared<DenseTensor>(
std::make_shared<phi::Allocation>(nullptr, 0, global_value->place()),
phi::DenseTensorMeta(global_value->meta()));
}
}

Expand Down