-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PIR]polish iterator of block #59118
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
5547d3c
to
70c003f
Compare
6799572
to
7345a80
Compare
7345a80
to
109458a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 这个「用法统一」太有用了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
单测删除误报
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
Others
Description
规范PIR下的Opetion、Region、Block的迭代器接口及使用方式。
此PR合入之前:PIR组件的遍历方式为:
如上所述,Operation没有定义迭代器,Region、Block的迭代器必须经两次解引用才可以获得相应的Block、Operaiton。
本PR为Operation、Region、Block定义了自己的专属迭代器。
本PR合入后,IR组件的遍历方式为:
本PR统一了Operaiton、Region、Block这三个PIR组件的遍历方式。
Other
Pcard-67164