Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prim][PIR] sqrt forward sink and fix Decomp bug #59135

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

kevincheng2
Copy link
Contributor

@kevincheng2 kevincheng2 commented Nov 19, 2023

PR types

New features

PR changes

Others

Description

During the sink of sqrt, it was found that each op_name may correspond to multiple op_kernel_func,causing an error in Decomp generation, so increasing op_kernel_func_name judgment, fix bug

Copy link

paddle-bot bot commented Nov 19, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 19, 2023
@kevincheng2 kevincheng2 changed the title [Prim][PIR] sqrt forward sink [Prim][PIR] sqrt forward sink and dix Decomp bug Nov 20, 2023
@kevincheng2 kevincheng2 changed the title [Prim][PIR] sqrt forward sink and dix Decomp bug [Prim][PIR] sqrt forward sink and fix Decomp bug Nov 20, 2023
Copy link
Contributor

@cyber-pioneer cyber-pioneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyber-pioneer cyber-pioneer merged commit 8321feb into PaddlePaddle:develop Nov 20, 2023
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
* sqrt prim sink c++

* prim sqrt sink c++

* remove sqrt op with python
@kevincheng2 kevincheng2 deleted the sqrt_prim_sink branch January 5, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants