Add ShapeAnalysisMgr #59254
Merged
Add ShapeAnalysisMgr #59254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
reviewed
Nov 22, 2023
| class IR_API ShapeAnalysisManager { | ||
| public: | ||
| static ShapeAnalysisManager& Instance(); | ||
| ShapeConstraintIRAnalysis& GetShapeConstraintIRAnalysis( |
There was a problem hiding this comment.
Suggested change
| ShapeConstraintIRAnalysis& GetShapeConstraintIRAnalysis( | |
| ShapeConstraintIRAnalysis& Get( |
Get是不是就可以了，简洁易用
|
|
||
| private: | ||
| ShapeAnalysisManager() {} | ||
| std::unordered_map<pir::Program*, ShapeConstraintIRAnalysis> tables_; |
There was a problem hiding this comment.
如之前沟通，在一些单测文件中，可能会包含很多个单测单元。在执行时，由于具有「时间连续性」，可能会出现A 测试单元的program 分配的地址是 0x123，执行完后回收资源；紧接着执行 B 测试单元，给新program分配的地址依旧是 0x123，导致此时从ShapeAnalysisManager查询得到的是A 中对应的 ShapeConstraintIRAnalysis，出现了「错位」，引发各种奇怪的错误
There was a problem hiding this comment.
经过讨论，通过在 program 中 d module op 加 id 解决
winter-wang
reviewed
Nov 26, 2023
| return instance; | ||
| } | ||
|
|
||
| ShapeConstraintIRAnalysis& ShapeAnalysisManager::Get(pir::Program* program) { |
There was a problem hiding this comment.
参数用 const Progran&会不会更好一点？ 不用担心指针为空的风险。
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* ShapeAnalysisMgr * singleton * UT * Werror=reorder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Other
Pcard-67164