【Hackathon 5th No.27】为 Paddle 新增 select_scatter API -part #59343

YibinLiu666 · 2023-11-24T07:59:41Z

PR types

Others

PR changes

APIs

Description

#57262
新增select_scatter API
RFC：PaddlePaddle/community#757

paddle-bot · 2023-11-24T07:59:46Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zoooo0820

从后续适配组合算子、AI编译器、接入新硬件等角度考虑，目前尽量是非必要不新增算子。由于这个算子的功能实际上是set_value的子集，不建议再新增算子，这个我们可以在RFC中进一步讨论，统一意见以后再实际写实现代码。

当然，从这个PR的kernel逻辑实现来看，预估会比set_value的kernel逻辑更高效。如果有兴趣的话，可以基于这个PR中kernel的实现逻辑，直接在set_value kernel中修改及优化，不过这已经超出了当前任务的范畴。

… select_scatter rebase and impl as RFC

YibinLiu666 · 2023-11-30T03:44:47Z

@zoooo0820 已经按RFC实现了该接口，麻烦您有空的时候review一下。

YibinLiu666 · 2023-12-01T02:08:50Z

@zoooo0820 CI都过了，麻烦您review一下

zoooo0820 · 2023-12-01T02:43:17Z

python/paddle/tensor/manipulation.py

+        )
+
+        # map var to the new output
+        paddle.jit.api.ProgramTranslator.get_instance()._inplace_map.add(


这部分是动转静用来适配python__setitem__内置返回值为None的，这里API可以正常返回output，所以这句不需要了

zoooo0820 · 2023-12-01T02:49:12Z

test/legacy_test/test_select_scatter_op.py

+            res = paddle.select_scatter(x_tensor, value_tensor, 1, 1)
+        except Exception as error:
+            self.assertIsInstance(error, RuntimeError)
+


这里查错辛苦直接用 self.assertRaises吧，否则后续如果某些修改导致try中语句能过了，这个单测会检测不到。

此外，这两个case能拆成两个函数吗，命名上再清晰一些说明是检查的什么case

zoooo0820 · 2023-12-01T02:53:24Z

python/paddle/tensor/manipulation.py

+                dtype=x.dtype
+            )
+        else:
+            output = helper.create_variable_for_type_inference(dtype=x.dtype)


这部分也是动转静用来适配python__setitem__内置返回值为None的，参考其他API写法，用else的分支即可

YibinLiu666 · 2023-12-01T08:28:07Z

@zoooo0820 CI已过，辛苦您再review一下

zoooo0820

LGTM

jeff41404 · 2023-12-05T03:54:58Z

python/paddle/tensor/manipulation.py

+    Embeds the values of the values tensor into x at the given index of axis.
+
+    Args:
+        x (Tensor) : The Destination Tensor.


should decribe x support what kinds of data types

YibinLiu666 · 2023-12-06T02:44:56Z

@jeff41404 修改doc之后LLM的CI不知道为什么一直过不了，coverage显示是我没修改的部分没覆盖到

luotao1 · 2023-12-06T02:48:49Z

LLM是非required CI，可以不用考虑
Coverage确实是本PR没修改的代码没覆盖到，可以最后豁免

jeff41404 · 2023-12-06T03:33:42Z

python/paddle/tensor/manipulation.py

+    Embeds the values of the values tensor into x at the given index of axis.
+
+    Args:
+        x (Tensor) : The Destination Tensor. Supported data types are `bool`, `float16`, `float32`, `float64`, `uint8`, `int8`, `int16`, `int32`, `int64`, `bfloat16`, `complex64`, `complex64`.


complex64, complex64 should be complex64, complex128 ?

jeff41404 · 2023-12-06T03:33:52Z

python/paddle/tensor/manipulation.py

+
+    Args:
+        x (Tensor) : The Destination Tensor. Supported data types are `bool`, `float16`, `float32`, `float64`, `uint8`, `int8`, `int16`, `int32`, `int64`, `bfloat16`, `complex64`, `complex64`.
+        values (Tensor) : The tensor to embed into x. Supported data types are `bool`, `float16`, `float32`, `float64`, `uint8`, `int8`, `int16`, `int32`, `int64`, `bfloat16`, `complex64`, `complex64`.


complex64, complex64 should be complex64, complex128 ?

luotao1 · 2023-12-06T03:39:14Z

可以提交对应的中文文档

sunzhongkai588

LGTM

support select_scatter op

c52c91d

paddle-bot bot added the contributor External developers label Nov 24, 2023

luotao1 added the PaddlePaddle Hackathon label Nov 24, 2023

luotao1 mentioned this pull request Nov 24, 2023

【PaddlePaddle Hackathon 5th】开源贡献个人挑战赛 #57262

Open

YibinLiu666 added 3 commits November 24, 2023 14:10

fix example code

19c0ab4

fix sc

0816c09

update example

b927bcf

zoooo0820 reviewed Nov 27, 2023

View reviewed changes

luotao1 assigned luotao1 and zoooo0820 Nov 29, 2023

YibinLiu666 added 3 commits November 30, 2023 03:24

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

06cf8b3

… select_scatter rebase and impl as RFC

remove unused files

3d1772c

add name

aadc948

PaddlePaddle locked and limited conversation to collaborators Nov 30, 2023

PaddlePaddle unlocked this conversation Nov 30, 2023

YibinLiu666 added 3 commits November 30, 2023 08:14

fix conflict

131d251

update

6512ec8

remove

d6ac9f6

zoooo0820 reviewed Dec 1, 2023

View reviewed changes

update

4573b2c

zoooo0820 approved these changes Dec 1, 2023

View reviewed changes

luotao1 assigned jeff41404 and sunzhongkai588 Dec 4, 2023

jeff41404 reviewed Dec 5, 2023

View reviewed changes

add type

195247c

jeff41404 reviewed Dec 6, 2023

View reviewed changes

update type

cd2bc76

sunzhongkai588 approved these changes Dec 6, 2023

View reviewed changes

luotao1 changed the title ~~【Hackathon 5th No.27】为 Paddle 新增 select_scatter API~~ 【Hackathon 5th No.27】为 Paddle 新增 select_scatter API -part Dec 6, 2023

YibinLiu666 mentioned this pull request Dec 6, 2023

【Hackathon 5th No.27】为 Paddle 新增 select_scatter API PaddlePaddle/docs#6352

Merged

luotao1 merged commit 3a0aeaa into PaddlePaddle:develop Dec 7, 2023
28 of 29 checks passed

YibinLiu666 mentioned this pull request Dec 8, 2023

[WeeklyReports] 2023.11.26~2023.12.10 周报收集 PFCCLab/Starter#37

Closed

26 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【Hackathon 5th No.27】为 Paddle 新增 select_scatter API -part #59343

【Hackathon 5th No.27】为 Paddle 新增 select_scatter API -part #59343

YibinLiu666 commented Nov 24, 2023 •

edited

Loading

paddle-bot bot commented Nov 24, 2023

zoooo0820 left a comment

YibinLiu666 commented Nov 30, 2023

YibinLiu666 commented Dec 1, 2023

zoooo0820 Dec 1, 2023

YibinLiu666 Dec 1, 2023

zoooo0820 Dec 1, 2023

YibinLiu666 Dec 1, 2023

zoooo0820 Dec 1, 2023

YibinLiu666 Dec 1, 2023

YibinLiu666 commented Dec 1, 2023

zoooo0820 left a comment

jeff41404 Dec 5, 2023

YibinLiu666 Dec 5, 2023

YibinLiu666 commented Dec 6, 2023

luotao1 commented Dec 6, 2023

jeff41404 Dec 6, 2023

YibinLiu666 Dec 6, 2023

jeff41404 Dec 6, 2023

YibinLiu666 Dec 6, 2023

luotao1 commented Dec 6, 2023

sunzhongkai588 left a comment

【Hackathon 5th No.27】为 Paddle 新增 select_scatter API -part #59343

【Hackathon 5th No.27】为 Paddle 新增 select_scatter API -part #59343

Conversation

YibinLiu666 commented Nov 24, 2023 • edited Loading

PR types

PR changes

Description

paddle-bot bot commented Nov 24, 2023

zoooo0820 left a comment

Choose a reason for hiding this comment

YibinLiu666 commented Nov 30, 2023

YibinLiu666 commented Dec 1, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YibinLiu666 commented Dec 1, 2023

zoooo0820 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YibinLiu666 commented Dec 6, 2023

luotao1 commented Dec 6, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luotao1 commented Dec 6, 2023

sunzhongkai588 left a comment

Choose a reason for hiding this comment

YibinLiu666 commented Nov 24, 2023 •

edited

Loading