Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FusedMultiTransformer optimization #59385

Merged

Conversation

RichardWooSJTU
Copy link
Contributor

PR types

New features

PR changes

OPs

Description

  • New fuse_mt op
  • Some tools for exporting

Copy link

paddle-bot bot commented Nov 27, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ RichardWooSJTU
❌ wufeisheng


wufeisheng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@RichardWooSJTU RichardWooSJTU changed the title [PPO Agent] Merge inference FusedMultiTransformer optimization Nov 28, 2023
@@ -246,6 +246,7 @@ PD_REGISTER_KERNEL(flash_attn_unpadded,
GPU,
ALL_LAYOUT,
phi::FlashAttnUnpaddedKernel,
float,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么注册这个类型?应该不支持?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为FuseMT算子注册了float类型,如果这里不注册会报链接错误;实际测试确实也没使用过float,我测试一下,如果确认不支持的话可能需要加Dispatch逻辑

@sneaxiy sneaxiy merged commit 6279a67 into PaddlePaddle:incubate/new_frl Dec 8, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants