Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR] polish the pir interface. #59392

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

winter-wang
Copy link
Contributor

@winter-wang winter-wang commented Nov 27, 2023

PR types

Others

PR changes

Others

Description

微调PIR接口:

  • Module::block()接口,由返回Block*调整为Block&。
  • WhileOp::body_block()接口,由返回Block*调整为Block&。

调整理由:这两个个接口返回的指针一定是非空的,因此由指针调整为引用。

Pcard-67164

Copy link

paddle-bot bot commented Nov 27, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@winter-wang winter-wang force-pushed the cf_develop branch 2 times, most recently from ef583ba to 3fed03d Compare November 27, 2023 07:32
kangguangli
kangguangli previously approved these changes Nov 27, 2023
@winter-wang winter-wang merged commit 4061ba7 into PaddlePaddle:develop Nov 27, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants