Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming conv2d_fusion op to fused_conv2d_add_act op #59431

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Renaming conv2d_fusion op to fused_conv2d_add_act op #59431

merged 3 commits into from
Dec 6, 2023

Conversation

yuanlehome
Copy link
Contributor

PR types

Others

PR changes

OPs

Description

根据上一个PR #58650 的comment建议，规范conv2d_fusion op的命名，将其改为fused_conv2d_add_act，同时批量更改相关的文件名/pass名/函数、类等对象名。

Others

Pcard-71500

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 28, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@yuanlehome
Copy link
Contributor Author

yuanlehome commented Nov 28, 2023 •
edited
Loading

XPU相关的这几个文件，麻烦相关同学看下，是否也同样可以更改？（当前PR没修改）

  1. xdnn算子库中的conv2d_fusion op
4492c31959252406bc54a912dcb74822
  1. 这几个pass里Conv2dFusion相关命名
2bf7aa4505534aa17667e56bbe0dea68

csy0225
csy0225 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@csy0225 csy0225 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XPU 相关的内容，phi 算子和 pass 层面应该也可以统一，但是为了区分 gpu 和 xpu 算子，需要加个算子标识，例如以 _xpu 后缀结尾。请鹏阳和洪明在评估一下。

@shentanyue
Copy link
Contributor

XPU相关的这几个文件，麻烦相关同学看下，是否也同样可以更改？（当前PR没修改）

  1. xdnn算子库中的conv2d_fusion op
4492c31959252406bc54a912dcb74822 2. 这几个pass里Conv2dFusion相关命名 2bf7aa4505534aa17667e56bbe0dea68

XPU相关的这几个文件，麻烦相关同学看下，是否也同样可以更改？（当前PR没修改）

  1. xdnn算子库中的conv2d_fusion op
4492c31959252406bc54a912dcb74822 2. 这几个pass里Conv2dFusion相关命名 2bf7aa4505534aa17667e56bbe0dea68

XDNN算子库的op名字应该难以更改，建议是保持原样。
不过Paddle里的XPU Pass的命名规范是同步改的

shentanyue
shentanyue previously approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@shentanyue shentanyue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XieYunshen
XieYunshen previously approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
单测重命名

@yuanlehome yuanlehome dismissed stale reviews from XieYunshen and shentanyue via a48a5ff December 5, 2023 06:50
XiaoguangHu01
XiaoguangHu01 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuanlehome yuanlehome merged commit 96e5988 into PaddlePaddle:develop Dec 6, 2023
29 checks passed
@kangguangli kangguangli mentioned this pull request Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@zyfncg zyfncg zyfncg approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

@Ligoml Ligoml Ligoml approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@csy0225 csy0225 csy0225 approved these changes

@shentanyue shentanyue shentanyue left review comments

@zhupengyang zhupengyang Awaiting requested review from zhupengyang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@yuanlehome @shentanyue @Aurelius84 @zyfncg @XieYunshen @Ligoml @XiaoguangHu01 @csy0225