【PIR API adaptor No.257】Migrate paddle.Tensor.gcd into pir #59452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
添加主函数后运行test_gcd.py可得到结果 然后就是持续的running，可能存在死循环 if __name__ == '__main__':
unittest.main() |
Closed
问题已收到，我尝试本地复现一下~ |
MarioLulab
reviewed
Dec 7, 2023
| @@ -5657,7 +5657,7 @@ def _gcd_body_fn(x, y): | |||
| ) | |||
| return (paddle.where(x < y, y, x), paddle.where(x < y, x, y)) | |||
|
|
|||
| if in_dynamic_mode(): | |||
| if in_dynamic_or_pir_mode(): | |||
There was a problem hiding this comment.
因为 pir 下与控制流相关的算子适配了静态图专用 api (比如下面的 paddle.static.nn.while_loop )，所以涉及控制流 api 可以复用旧静态图构图分支。这里可以复原
Suggested change
| if in_dynamic_or_pir_mode(): | |
| if in_dynamic_mode(): |
|
gcd 的适配有另一个开发者（“敏师傅”）已经完成了，#59600 ~ 当前 PR 就先关掉了，有空的时候可以推进一下其他的 pr 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
#58067
PIR API 推全升级
将算子迁移升级至 pir，并更新单测
paddle.Tensor.gcd（0/5）：添加test_with_pir_api时单测卡住没有结果