Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.253、310】Migrate cumulative_trapezoid,trapezoid into pir #59481

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Nov 29, 2023

PR types

Others

PR changes

APIs

Description

PIR API 推全升级

  • 新IR Python API适配升级 #58067
    No.253 paddle.cumulative_trapezoid
    No.310 paddle.Tensor.trapezoid
    paddle.cumulative_trapezoid 迁移升级至 pir,并更新单测 单测覆盖率 9/9
    paddle.Tensor.trapezoid 迁移升级至 pir,并更新单测 单测覆盖率 13/13

cumulative_trapezoid和trapezoid 都是调用的 _trapezoid
根据传入参数判断是使用sum还是cumsum。
trapezoid 用sum
cumulative_trapezoid 用 cumsum。
sum和cumsum前期都已完成迁移。

Copy link

paddle-bot bot commented Nov 29, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 29, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 29, 2023
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

麻烦在 pr 描述里补充一下单测覆盖率~

Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit f6de2c7 into PaddlePaddle:develop Dec 4, 2023
@enkilee enkilee deleted the pir-api-253-310 branch December 14, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants