-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add type promotion logic for eager between tensor and tensor #59518
Merged
jeff41404
merged 23 commits into
PaddlePaddle:develop
from
zxcd:type_promotion_stage1_eager_T_T
Dec 7, 2023
Merged
add type promotion logic for eager between tensor and tensor #59518
jeff41404
merged 23 commits into
PaddlePaddle:develop
from
zxcd:type_promotion_stage1_eager_T_T
Dec 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献! |
zoooo0820
reviewed
Dec 4, 2023
zoooo0820
reviewed
Dec 4, 2023
jeff41404
previously approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zyfncg
reviewed
Dec 6, 2023
zyfncg
approved these changes
Dec 6, 2023
jeff41404
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
Card-64022
add type promotion logic for eager between tensor and tensor.
stage 1 will only support float in "+ - *, where" API.
Example like: