Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR OpTest Fix No.5】 fix test_tril_triu_op #59734

Merged
merged 5 commits into from
Dec 25, 2023

Conversation

xingmingyyj
Copy link
Contributor

PR types

Others

PR changes

Others

Description

PIR Op单测修复
修复单测 test_tril_triu_op
修复后打开FLAGS_enable_pir_in_executor单测是否通过:否

paddle::operators::DataOp::GetExpectedKernelType(paddle::framework::ExecutionContext const&) const
 FatalError: `Segmentation fault` is detected by the operating system.

Copy link

paddle-bot bot commented Dec 6, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Dec 6, 2023
@kangguangli
Copy link
Contributor

这个比较特殊一点,我们在paddle/fluid/ir_adaptor/translator/op_translator.cc里面定义了对这个算子的特殊转换,会把他分别翻译到两个算子,不过之前只处理了前向,现在对反向也做类似处理吧

@xingmingyyj
Copy link
Contributor Author

这个比较特殊一点,我们在paddle/fluid/ir_adaptor/translator/op_translator.cc里面定义了对这个算子的特殊转换,会把他分别翻译到两个算子,不过之前只处理了前向,现在对反向也做类似处理吧

好的

@xingmingyyj xingmingyyj force-pushed the fix_test_tril_triu_op branch from 163b889 to 2b79908 Compare December 13, 2023 06:23
Copy link
Contributor

@kangguangli kangguangli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

得添加 test_tril_triu_op 到监控列表才行吧

@xingmingyyj
Copy link
Contributor Author

得添加 test_tril_triu_op 到监控列表才行吧

忘记了,已添加

@kangguangli kangguangli merged commit 644cbcc into PaddlePaddle:develop Dec 25, 2023
29 checks passed
@xingmingyyj xingmingyyj deleted the fix_test_tril_triu_op branch December 25, 2023 08:06
Wanglongzhi2001 pushed a commit to Wanglongzhi2001/Paddle that referenced this pull request Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants