Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SOT][3.11] Skip frame when code has listcomp or genexpr #59816

Merged

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Dec 7, 2023

PR types

Bug fixes

PR changes

Others

Description

3.11 在 RESUME 里多次 warmup 之后 Quicken 的代码会导致段错误,该问题仅在代码中含 listcompgenexpr 相关代码的情况下会复现,因此现阶段在遇到该情况下直接 Fallback,确保功能正确性

PCard-66972

Copy link

paddle-bot bot commented Dec 7, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@SigureMo SigureMo changed the title [SOT][3.11] Skip frame when code has listcomp or genexpr [SOT][3.11] Skip frame when code has listcomp or genexpr Dec 7, 2023
Copy link
Contributor

@2742195759 2742195759 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo SigureMo merged commit 4519899 into PaddlePaddle:develop Dec 8, 2023
@SigureMo SigureMo deleted the sot/fallback-when-code-has-listcomp branch December 8, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants