Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【PIR OpTest Fix No.31】 fix test_number_count_op #60055

Merged
merged 11 commits into from
Dec 18, 2023
Merged

【PIR OpTest Fix No.31】 fix test_number_count_op #60055

merged 11 commits into from
Dec 18, 2023

Conversation

DrRyanHuang
Copy link
Member

@DrRyanHuang DrRyanHuang commented Dec 15, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

FLAGS_enbale_pir_in_executpr=1 ctest -R test_number_count_op 可以成功执行

image

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Dec 15, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Dec 15, 2023
@luotao1 luotao1 mentioned this pull request Dec 15, 2023
Closed
kangguangli
kangguangli approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@kangguangli kangguangli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 但是现在只是在CI里监控了部分单测，还希望能执行下下面这条命令 FLAGS_enbale_pir_in_executpr=1 ctest -R test_number_count_op
看看有无报错，如果有问题只要记录下就可以了，由我们后续来推进修复。

@kangguangli kangguangli merged commit 1fabb45 into PaddlePaddle:develop Dec 18, 2023
29 checks passed
@DrRyanHuang DrRyanHuang deleted the piropfix/test_number_count_op branch December 18, 2023 11:44
HermitSun pushed a commit to HermitSun/Paddle that referenced this pull request Dec 21, 2023
@DrRyanHuang @HermitSun
【PIR OpTest Fix No.31】 fix test_number_count_op (PaddlePaddle#60055)
09d434a 
* add numbercount

* add number_count to NEED_GEN_STATIC_ONLY_APIS

* revert ops_api_gen

* add NEED_GEN_STATIC_ONLY_APIS to number_count

* numbers => Numbers

* numbers => Numbers in py

* numbers => Numbers

* fix data_type err && Numbers|numbers err

* Number revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzhang533 jzhang533 jzhang533 approved these changes

@jeff41404 jeff41404 jeff41404 approved these changes

@kangguangli kangguangli kangguangli approved these changes

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DrRyanHuang @jzhang533 @jeff41404 @kangguangli