-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PIR] OneDNN Pir onednn instruction #60257
[PIR] OneDNN Pir onednn instruction #60257
Conversation
paddle/fluid/framework/new_executor/instruction/onednn/onednn_phi_kernel_instruction.cc
Outdated
Show resolved
Hide resolved
… pir_onednn_instruction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for program translator part.
8ca1f82
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -5,6 +5,24 @@ if(NOT (WITH_CINN AND NOT CINN_ONLY)) | |||
${CMAKE_CURRENT_SOURCE_DIR}/instruction/cinn_jit_instruction.cc) | |||
endif() | |||
|
|||
if(NOT WITH_MKLDNN) | |||
list( | |||
REMOVE_ITEM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REMOVE_ITEM支持移除多个,可以合并:https://cmake.org/cmake/help/v3.0/command/list.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* onednn dialect gend
PR types
New features
PR changes
Others
Description
PIR支持OneDNN,机制建设——OneDNN Dialect添加。
目前,本地测试Program中有use_mkldnn的单测,经过ProgramTranslator已经能够成功运行到Instruction。
并支持了OneDNNPhiKernelInstruction,并跑通了Conv2d。
IR转换如下:
Pcard-67164