【PIR Dist Op Reg No.13】 reg partial_send #60484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
|
该算子只在with_distribute开启的情况下编译，因此需要修改 |
Difers
force-pushed
the
reg_pir_partial_send
branch
4 times, most recently
from
55d37d2
to
b1ac26b
Compare
kangguangli
reviewed
Jan 8, 2024
Comment on lines
8
to
9
| set(DISTRIBUTED_OP_TRANSLATION_TEST test_c_reduce_min_translate) | ||
| set(DISTRIBUTED_OP_TRANSLATION_TEST test_partial_send_translate) |
There was a problem hiding this comment.
Suggested change
| set(DISTRIBUTED_OP_TRANSLATION_TEST test_c_reduce_min_translate) | |
| set(DISTRIBUTED_OP_TRANSLATION_TEST test_partial_send_translate) | |
| list(APPEND DISTRIBUTED_OP_TRANSLATION_TEST test_partial_send_translate) |
应该这样改，之前的说法也有问题，删掉了
There was a problem hiding this comment.
Suggested change
| set(DISTRIBUTED_OP_TRANSLATION_TEST test_c_reduce_min_translate) | |
| set(DISTRIBUTED_OP_TRANSLATION_TEST test_partial_send_translate) | |
| set(DISTRIBUTED_OP_TRANSLATION_TEST | |
| test_c_reduce_min_translate | |
| test_partial_send_translate) |
另一种改法是这样的
Difers
force-pushed
the
reg_pir_partial_send
branch
from
b1ac26b
to
4bb8ba6
Compare
kangguangli
reviewed
Jan 10, 2024
| @@ -4,7 +4,8 @@ file( | |||
| "test_*.py") | |||
| string(REPLACE ".py" "" TEST_INTERP_CASES "${TEST_INTERP_CASES}") | |||
|
|
|||
| set(DISTRIBUTED_OP_TRANSLATOR_TEST test_c_reduce_min_translator) | |||
| set(DISTRIBUTED_OP_TRANSLATION_TEST test_c_reduce_min_translator | |||
There was a problem hiding this comment.
Suggested change
| set(DISTRIBUTED_OP_TRANSLATION_TEST test_c_reduce_min_translator | |
| set(DISTRIBUTED_OP_TRANSLATOR_TEST test_c_reduce_min_translator |
这里写错了导致下面没生效
Difers
force-pushed
the
reg_pir_partial_send
branch
from
4bb8ba6
to
96c1f35
Compare
|
@Difers 可以解决下冲突，应该可以合入了 |
Difers
force-pushed
the
reg_pir_partial_send
branch
from
96c1f35
to
6789505
Compare
好的 |
|
麻烦修改一下PR描述，可以推进合入了 |
kangguangli
reviewed
Jan 24, 2024
| @@ -1565,6 +1565,16 @@ | |||
| kernel: | |||
| func: onednn_to_paddle_layout | |||
|
|
|||
| - op: partial_send | |||
| args: (Tensor x, int ring_id = 0, int peer = 0, bool use_calc_stream = false, int num = 1, int id = 0) | |||
| output: Tensor(out) | |||
There was a problem hiding this comment.
Suggested change
| output: Tensor(out) | |
| output: |
这个算子是没有输出的，其他地方也需要相应修改
|
Sorry to inform you that 6789505's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
Difers
force-pushed
the
reg_pir_partial_send
branch
from
6789505
to
a58c1e6
Compare
|
@Difers 别忘了这个PR哈 |
Difers
force-pushed
the
reg_pir_partial_send
branch
from
a58c1e6
to
2117ed7
Compare
Difers
force-pushed
the
reg_pir_partial_send
branch
from
2117ed7
to
1e1f5fb
Compare
|
@kangguangli 辛苦有时间再review下～ |
kangguangli
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description