Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_with_pir_api in error test #60693

Merged
merged 8 commits into from
Jan 22, 2024

Conversation

zrr1999
Copy link
Member

@zrr1999 zrr1999 commented Jan 10, 2024

PR types

Others

PR changes

Others

Description

#60488
大部分的 test_error 添加 test_with_pir_api 已经在之前的pr中进行了总结和测试,本 PR 先将可直接添加装饰器不需要额外修改的部分合入。

下列 API 单测 test_errors 适配 PIR:
image

  • numel
  • unsqueeze
  • arrange
  • greater_equal
  • reshape

Copy link

paddle-bot bot commented Jan 10, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -531,6 +533,7 @@ def test_out_dtype():


class TestSumOpError(unittest.TestCase):
@test_with_pir_api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是动态图的测试case,不需要装饰

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,已修改

@0x45f
Copy link
Contributor

0x45f commented Jan 17, 2024

test_sum_op单测在windows上挂了,尝试在test_errors的每个测试函数中用with program_guard(xx)包一下试试呢~ 我感觉是program混用的问题,有一些同名的value

@zrr1999
Copy link
Member Author

zrr1999 commented Jan 17, 2024

test_sum_op单测在windows上挂了,尝试在test_errors的每个测试函数中用with program_guard(xx)包一下试试呢~ 我感觉是program混用的问题,有一些同名的value

好的,已修改,然后添加了一下reshape

@zrr1999 zrr1999 requested a review from 0x45f January 20, 2024 04:31
@0x45f 0x45f merged commit 3dfe88e into PaddlePaddle:develop Jan 22, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants